Make GraphML.Writer use vertexID and edgeEndpoints#42
Open
debug-ito wants to merge 3 commits intotuura:masterfrom
Open
Make GraphML.Writer use vertexID and edgeEndpoints#42debug-ito wants to merge 3 commits intotuura:masterfrom
debug-ito wants to merge 3 commits intotuura:masterfrom
Conversation
to generate "id", "source" and "target" attributes. If they are already defined in vertexAttributes or edgeAttributes, those are ignored.
nodes are ordered by the ID.
Member
|
I'd like @thisiswhereitype to have a look. |
Collaborator
|
For what is worth this was behaviour was intentional when I wrote this but with some more experience I agree a change is needed. I will review this code carefully but I am overall concerned about consistent treatment across parsers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #41.
To keep backward-compatibility, now "id", "source" and "target" attributes stored in Vertex or Edge are ignored. Those attributes in the output are now provided by
vertexIDandedgeEndpoints.