Implement full varargs support for Lua 5.3 #130
Merged
+393
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydog187
commented
Feb 11, 2026
lib/lua/compiler/codegen.ex
Outdated
|
|
||
| multiple -> | ||
| base_reg = ctx.next_reg | ||
| multiple when length(multiple) > 1 -> |
Contributor
Author
There was a problem hiding this comment.
use pattern matching
davydog187
commented
Feb 11, 2026
lib/lua/compiler/codegen.ex
Outdated
Comment on lines
132
to
134
| if value_reg == target_reg, | ||
| do: [], | ||
| else: [Instruction.move(target_reg, value_reg)] |
Contributor
Author
There was a problem hiding this comment.
we should integrate styler here
Contributor
Author
There was a problem hiding this comment.
dont use this if syntax, remove the keyword syntax
Implements comprehensive varargs (`...`) support including:
**Compiler changes:**
- Detect when `...` is the last value in return statements and generate
vararg expansion with variable return count
- Detect when `...` is the last element in table constructors and generate
vararg expansion for list fields
- Detect when `...` is the last argument in function calls and generate
vararg expansion with encoded arg counts
- Use negative arg counts in call instructions to encode fixed args + varargs
**VM changes:**
- Update vararg instruction to support count==0 meaning "load all varargs"
- Update return instruction to support count==-1 meaning "return all values
including expanded varargs"
- Update set_list instruction to support count==0 meaning "variable number
of values from varargs"
- Update call instruction to decode negative arg counts as fixed + varargs
**Features supported:**
- Simple varargs: `function f(...) return ... end`
- Mixed params: `function f(a, b, ...) return a, b, ... end`
- Varargs in tables: `{...}` and `{a, b, ...}`
- Varargs in function calls: `g(...)` and `g(a, b, ...)`
- Empty varargs handling
- Works with select('#', ...) and other stdlib functions
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Use pattern matching instead of length guard - Replace if/do/else keyword syntax with regular if/else/end blocks
davydog187
force-pushed
the
add-varargs-support
branch
from
d924f71 to
504a0d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...) support for Lua 5.3 compatibilityvararg.luaChanges
Compiler
return a, b, ...and generates vararg expansion with variable return count{a, b, ...}and generates vararg expansion for list fieldsf(a, b, ...)and generates vararg expansion with encoded arg countsVM
count==0to load all varargs into consecutive registerscount==-1to return all values including expanded varargscount==0for variable number of values from varargsFeatures Supported
function f(...) return ... endfunction f(a, b, ...) return a, b, ... end{...}and{a, b, ...}g(...)andg(a, b, ...)select('#', ...)and other stdlib functionsTest Results
🤖 Generated with Claude Code