Open
Conversation
This is because BridgeStan is not Nix-packaged yet and thus would make for a missing import if a user uses the Nix derivation in `examples/nix/chainsail_helpers.nix` and then only wants to use the httpstan wrapper.
This is for BridgeStan compatibility. BridgeStan requires at least Python 3.9.
cdc764d to
f96f0e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a BridgeStan (https://github.com/roualdes/bridgestan) wrapper to the list of PDF interface implementations. Together with tweag/chainsail#480, this allows for much faster sampling of Stan models.
This change also includes a refactoring of the
chainsail_helpers.pdf.stanmodule into two submodules,httpstanandbridgestan, each containing the respective wrappers. This also has the advantage of making thechainsail-helpershttpstanwrapper usable without having to have BridgeStan installed (which can be a bit of a hassle).