Skip to content

Conversation

@arwoll
Copy link

@arwoll arwoll commented Nov 5, 2021

Vicente:

This is a "test" pull request -- which is directed at your "develop" branch rather than "master" - in order for you to test it outside your master branch, though I notice your develop branch is a little behind master.

Note that the fork I am pulling from was created from your master branch, so accepting this pull request would include the changes you made between those branches.

I am not experienced at doing pull requests! So please let me know if I am doing something wrong or for any other reason you need to reject this request. that's OK!

This pull request incorporates two changes:

  1. Changes the "python" subdirectory to "pyspec": For me, this change (along with a minor edit to setup.py) was necessary to make the github source installable on my mac.
  2. Changes the motor_positions_list from a list to a dict, so that e.g. scan.motor_positions['motor1'] returns the motor value. This strikes me as the intended behavior. Instead, the prior version makes a list of tuples.

-Arthur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants