Some maintenance #34
Merged
Some maintenance #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern PHP releases do not support old and insecure TLS versions anymore. In general it's not advised to let end users decide on the TLS version or hardcode those versions into the library, since these things change and you run the risk running an outdated version. For example the code did not support TLS1.3 before this patch, because only 1.2 was known at the time of writing the original code. This patch ignores the passed version and will always let PHP pick the recommended versions.
Travis seems to have been broken for a while anyway.
The code was using short array syntax already, this only makes the composer file reflect the code requirements.
There should not be an error thrown before our own Exception is thrown.
This is mostly autogenerated for now but should provide a good starting point for proper testing of the message class.
This should disable certificate validation when allowInsecure is set to true similar to when SSL connections are used. This is currently untested.
when running test on github actions, we can not run multiple tests at the same time or we will run into the mailtrap request limits.
On older php versions you may not pass a null context to stream_socket_client(). This path creates a empty standard context instead. The exception message has been extended to give more detail about the failed connection. The commented stream blocking code has been removed. The connection is opened in blocking mode by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some maintainance work. All changes should be separated into individual commits, so it should be easy to see what was done. Mostly: