Fix FFI compatibility with gleam_stdlib export changes #14
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update JavaScript FFI to use new export naming conventions and fix issue with accessing Dict in the latest stdlib.
Owner
|
Thanks for your contribution! I'll look further at this soon, hopefully. I think we'll need to update the stdlib dep req too. |
Author
|
The dict.get was available in the stdlib version used; I ran this code on the pinned deps. The rest of the changes will require updating the gleam version in CI to something more recent. |
Owner
|
Oh right, great point. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest stdlib reworked Dicts quite a bit, and the JS FFI in shellout was relying on internals to function. This PR updates the JS FFI to use the API's documented in the externals guide. The error I was getting was: