feat: allow using version ranges to cope with stale Maven Local cache#1611
Merged
feat: allow using version ranges to cope with stale Maven Local cache#1611
Conversation
This was referenced Aug 19, 2024
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Vampire
force-pushed
the
vampire/version-range-support
branch
from
bfe88c2 to
5f291dc
Compare
This was referenced Aug 19, 2024
Vampire
force-pushed
the
vampire/fix-metadata-file
branch
from
ba37150 to
6ca3d30
Compare
Vampire
force-pushed
the
vampire/version-range-support
branch
from
5f291dc to
09633a4
Compare
This was referenced Aug 20, 2024
Vampire
force-pushed
the
vampire/fix-metadata-file
branch
from
6ca3d30 to
af0de7b
Compare
Vampire
force-pushed
the
vampire/version-range-support
branch
from
09633a4 to
cb4a8a3
Compare
Vampire
force-pushed
the
vampire/fix-metadata-file
branch
from
af0de7b to
80db505
Compare
Vampire
force-pushed
the
vampire/version-range-support
branch
from
cb4a8a3 to
d9a036e
Compare
Vampire
force-pushed
the
vampire/fix-metadata-file
branch
from
80db505 to
6df8a27
Compare
Vampire
force-pushed
the
vampire/version-range-support
branch
from
d9a036e to
a7e496f
Compare
Vampire
force-pushed
the
vampire/fix-metadata-file
branch
from
6df8a27 to
cd832fe
Compare
Vampire
force-pushed
the
vampire/version-range-support
branch
from
a7e496f to
ef9782d
Compare
Vampire
force-pushed
the
vampire/fix-metadata-file
branch
from
cd832fe to
c8aeae6
Compare
krzema12
added a commit
that referenced
this pull request
Feb 24, 2025
Related to #1611. We're going to make some changes in the function, so let's add some safety net to prevent regressions + a way to see how the modified function behaves. --------- Co-authored-by: Björn Kautler <Bjoern@Kautler.net>
Vampire
force-pushed
the
vampire/version-range-support
branch
from
26c5bb1 to
d0a6ac3
Compare
Vampire
changed the base branch from
graphite-base/1611
to
vampire/fix-version-comparison
krzema12
reviewed
Feb 24, 2025
...src/test/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuildingTest.kt
Outdated
Show resolved
Hide resolved
Vampire
changed the base branch from
vampire/fix-version-comparison
to
graphite-base/1611
Vampire
force-pushed
the
graphite-base/1611
branch
from
229dd5f to
8e28deb
Compare
Vampire
force-pushed
the
vampire/version-range-support
branch
from
d0a6ac3 to
3f9ac7d
Compare
Vampire
changed the base branch from
graphite-base/1611
to
vampire/fix-version-comparison
Vampire
force-pushed
the
vampire/version-range-support
branch
from
3f9ac7d to
9321528
Compare
krzema12
reviewed
Feb 24, 2025
Member
krzema12
left a comment
krzema12
left a comment
There was a problem hiding this comment.
I think this is the last review round 😄
...g-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/ActionCoords.kt
Show resolved
Hide resolved
...main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords.kt
Show resolved
Hide resolved
…minor version even with more detailed version
Vampire
force-pushed
the
vampire/version-range-support
branch
from
9321528 to
2cbfbfc
Compare
Collaborator
Author
|
We'll see :-D |
Vampire
force-pushed
the
vampire/version-range-support
branch
from
e161253 to
9a0da25
Compare
krzema12
approved these changes
Feb 25, 2025
krzema12
changed the title
krzema12
changed the title
Member
|
@Vampire thanks, and sorry for the long wait - I'm trying my best to reduce the backlog of PRs 😄 I think the strategy to focus on mutually iterating on a single PR works really well, lets me focus properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes you can for example depend on
actions:cache__save___major:[v4,v5)"and get the latest v4 action with latest v4 typing by resolving to a concrete v4.x.y version but the output still contains justv4.The same for
actions:cache__save___minor:[v4.0,v4.1), to get the latest v4.0 but in the output just havev4.0.