-
Notifications
You must be signed in to change notification settings - Fork 5
docs: Change license to Business Source License 1.1 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for merry-cranachan-ee7f1c canceled.
|
PR Review: Change license to Business Source License 1.1Thank you for the clear PR description and rationale. I've reviewed the licensing change and have the following feedback: ✅ Strengths
🔍 Observations & Suggestions1. PR Title Format Issue (Blocking CI)The PR title doesn't follow the conventional commit format required by your lint check. It should be: or 2. CONTRIBUTING.md Should Be UpdatedThe CONTRIBUTING.md file currently makes no mention of licensing or CLAs. Consider adding a section that clarifies:
This is important for both legal clarity and contributor transparency. 3. Package Metadata ConsiderationsWhile the main package.json files don't currently have a "license" field (they're marked "private": true), if you ever publish npm packages or Maven artifacts, you'll need to ensure the license field is set to "BUSL-1.1" or document the custom license appropriately. 4. License Year ParameterThe LICENSE file states: Since we're now in 2026, consider whether this should be:
The standard practice is typically to update the year range, but this depends on your legal counsel's advice. 5. Change Date AmbiguityThe license states: "Four years from the date the Licensed Work is published" Consider specifying an exact date (e.g., "2028-01-20") or a more precise mechanism. The current language could be interpreted differently depending on what "published" means (first commit? first release? this license change date?). 🔒 Security & Legal
🧪 Test CoverageThis change is documentation-only and doesn't require automated tests. Manual verification checklist:
📋 Additional Considerations
SummaryThis is a well-executed license change with clear communication. The main blocker is the PR title format for CI. The suggested improvements around CONTRIBUTING.md and the copyright year are minor but would improve completeness. Recommendation: ✅ Approve after fixing PR title and considering the CONTRIBUTING.md update. Review generated by Claude Code v0.2 |
Summary
Why BSL?
We're a small team building TypeStream in the open. The BSL lets us:
This follows the model used by MariaDB, CockroachDB, Sentry, and HashiCorp.
Test plan