Conversation
Updated the footer copyright year to be dynamically generated using
the current year instead of a hardcoded 2023 value.
- Added currentYear context variable to vite.config.js using new Date().getFullYear()
- Updated footer.html to use {{currentYear}} Handlebars variable
Closes #214
Co-authored-by: Jevin Maltais <jevy@users.noreply.github.com>
Deploying typestream with
|
| Latest commit: |
6ad840e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c02cf2b7.typestream.pages.dev |
| Branch Preview URL: | https://claude-issue-214-20260130-22-lddp.typestream.pages.dev |
Pull Request ReviewSummaryThis PR successfully addresses issue #214 by making the footer copyright year dynamic. The implementation replaces a hardcoded "2023" with a dynamic year that will automatically update. ✅ Positives
🔍 Considerations & Suggestions1. Build-Time vs RuntimeThe current implementation generates the year at build time using
Impact: If the site is built on December 31st and not rebuilt on January 1st, the copyright year will be outdated until the next deployment. Recommendation: This is typically acceptable for marketing sites that deploy regularly. However, if deployment frequency is a concern, consider documenting this in a comment in context: {
// Note: Year is set at build time. Site must be rebuilt in the new year.
currentYear: new Date().getFullYear(),
},2. Test CoverageThere are no automated tests for this change. For a simple footer update this is reasonable, but consider:
3. Search for Other Hardcoded YearsI ran a search and confirmed there are no other hardcoded year references in the HTML files that need updating. Good job being thorough! ✅ 🎯 Code Quality Assessment
📋 Checklist
✨ VerdictLGTM (Looks Good To Me) - This is a clean, straightforward fix that solves the issue appropriately. The implementation is correct and follows best practices for a Vite + Handlebars static site. The only minor consideration is the build-time vs runtime year generation, but for a marketing website with regular deployments, this approach is perfectly acceptable and arguably preferable (simpler, faster, no client-side JS needed). Recommendation: ✅ Approve and merge |
Updated the footer copyright year to be dynamically generated using the current year instead of a hardcoded 2023 value.
Closes #214
Generated with Claude Code