tmc::fork_group can be awaited multiple times
#202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
tmc::fork_groupwas an rvalue-only awaitable, like most other TMC awaitables. This restriction makes sense for awaitables that initiate work and retrieve results in the same operation (since initiating work is not idempotent). However,fork_groupseparates the steps of initiating work and awaiting it. So we can make it an lvalue awaitable which can be awaited multiple times to retrieve the same result again. Or the user can still cast to rvalue to move-from the result. If the user wants to dispatch another group of work later, they can callreset()before doing so.This allows it to replace
tmc::manual_reset_eventin some places, with a caveat: awaitingmanual_reset_eventis thread-safe as it has a mechanism to register multiple awaiters, butfork_groupdoes not. So only a single thread should awaitfork_groupat any given time.Supported usages:
co_await fg; // returns ResultArray&co_await std::move(fg); // returns ResultArray&&std::move(co_await fg); // returns ResultArray&&