Add ability to resize an existing circle by clicking twice#525
Open
StijnAmeloot wants to merge 3 commits intouber:masterfrom
Open
Add ability to resize an existing circle by clicking twice#525StijnAmeloot wants to merge 3 commits intouber:masterfrom
StijnAmeloot wants to merge 3 commits intouber:masterfrom
Conversation
Pull Request Test Coverage Report for Build 2290
💛 - Coveralls |
Contributor
Author
|
Fixed a small issue and added a gif which shows the two different modes. |
igorDykhta
reviewed
Dec 21, 2022
Collaborator
igorDykhta
left a comment
There was a problem hiding this comment.
- I think dragToDraw: true should be by default
- Not sure how the mode with dragToDraw: false should work. I activated the resizing mode, then I clicked anywhere, no response at this point, then the circle starts to resize with any mouse movement, then I need to click to finish resizing. I assume the resizing should only start after clicking on the small helper circle which appears on the edge of the circle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default a circle can now be resized by clicking twice along the ring.
The 'dragToDraw' option has been added to the mode config to enable dragging instead of clicking twice.
Example (shows first the two-click mode and after that the drag to draw mode)
