Adds onCancelPan optional prop and adds more calls to cancelPan#887
Open
alex-bain wants to merge 1 commit intouber:masterfrom
Open
Adds onCancelPan optional prop and adds more calls to cancelPan#887alex-bain wants to merge 1 commit intouber:masterfrom
alex-bain wants to merge 1 commit intouber:masterfrom
Conversation
|
|
Collaborator
|
Thanks for opening this. In particular, appreciate that docs were added. Testing interactive functions is tricky, but it possible to add a test case or two? |
Collaborator
|
@igorDykhta If possible let's see if we can help @alex-bain land this |
igorDykhta
approved these changes
Oct 30, 2023
igorDykhta
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello - thank you for building NebulaGL, it is a fantastic library.
This PR contains two small changes:
onCancelPanprop toeditable-layer, allowing developers to execute their own logic when NebulaGL determines a map panning operation should be interruptedevent.cancelPan()invocations for additionalEditModesto ensureevent.cancelPanis always being called at the appropriate time