feat: add DrawLineStringByDraggingMode ("Pencil" mode)#897
Open
ben-xD wants to merge 3 commits intouber:masterfrom
Open
feat: add DrawLineStringByDraggingMode ("Pencil" mode)#897ben-xD wants to merge 3 commits intouber:masterfrom
DrawLineStringByDraggingMode ("Pencil" mode)#897ben-xD wants to merge 3 commits intouber:masterfrom
Conversation
|
|
ben-xD
force-pushed
the
DrawLineStringByDraggingMode
branch
from
98c3ee9 to
4058fbd
Compare
ben-xD
force-pushed
the
DrawLineStringByDraggingMode
branch
from
4058fbd to
ae7a731
Compare
ibgreen
approved these changes
Mar 11, 2024
Collaborator
ibgreen
left a comment
ibgreen
left a comment
There was a problem hiding this comment.
This looks very neat!
- Add a bullet to https://github.com/uber/nebula.gl/blob/master/docs/whats-new.md ?
- Possible to add a test case?
Author
Collaborator
|
Erm, I just realized that we no longer have write access to this repository, meaning I can't merge your PR. I am afraid that the plan is to move nebula.gl code over to a new |
Author
|
No worries, looking forward to a deck.gl community package! I'm happy to re-open it there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented this for https://geojsons.com/, it's used by the pencil tool
pencil.mp4
I believe that is also what #172 requested, but we got the (also very useful)
DrawPolygonByDraggingModeIn the example app
PS: I still need to get things building in nebula.gl and then try this out in the example app.linestring.mp4