This repository was archived by the owner on Nov 27, 2022. It is now read-only.
Fix video format sorting function to fix Aethercast FTBFS #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 18e54e7 (Fix video formats handling code) converts "operator <" to sort comparision function itself. However, it doesn't invert the operator inside it. This means now video formats are sorted from small to large instead of from large to small. This commit inverts the operator inside the function, so that it now sort correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a regression in wds, there's a test in Aethercast that make sure wds sorts video format correctly. Ubuntu patched it with a distribution patch. However, our import, being in Debian-native mode, doesn't take that patch into account. This causes Aethercast to FTBFS.
This PR brings in the fixing commit by merging. This very same commit is already in a pull request to upstream [1]. Doing this helps reduce the chance of merge conflict in the future.
[1] intel#191