Fix PAM session termination in child process to support deferred pam_cap operations#414
Open
wngtk wants to merge 1 commit intoubuntu:mainfrom
Open
Fix PAM session termination in child process to support deferred pam_cap operations#414wngtk wants to merge 1 commit intoubuntu:mainfrom
wngtk wants to merge 1 commit intoubuntu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pam_cap.so module with the
deferoption fails to apply capabilities correctly when logging in through LightDM. While the configuration works with text-based login (as fixed in shadow-maint/shadow#408), LightDM doesn't properly terminate the PAM session in the child process, preventing deferred capability assignment from taking effect during graphical login sessions.Example Configuration:
Background:
defer: pam_cap sets capabilities through pam_setcred()defer: pam_cap relies on pam_end() to finalize capability assignmentComparison with GDM:
Works correctly with pam_cap because it properly calls
pam_setcred()aftersetuid(). This correct behavior means thedeferoption is not required for GDM to function with pam_cap.