Skip to content

Conversation

@nss10
Copy link
Contributor

@nss10 nss10 commented Aug 5, 2025

Link to JIRA ticket if there is one: MIDRC-1098

Improvements

  • Fix: prevent Poetry install from running on every launch

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Aug 5, 2025

Pull Request Test Coverage Report for Build 16996583692

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.404%

Totals Coverage Status
Change from base Build 16608366178: 0.0%
Covered Lines: 569
Relevant Lines: 651

💛 - Coveralls

@nss10 nss10 changed the title Move poetry install from common_setup and run it before _setup_db Update Prometheus setup and '/metrics' endpoint Aug 5, 2025
@nss10 nss10 changed the title Update Prometheus setup and '/metrics' endpoint Update Prometheus setup and /metrics endpoint Aug 5, 2025
@nss10 nss10 requested review from paulineribeyre and removed request for paulineribeyre August 5, 2025 21:09
@nss10 nss10 requested a review from paulineribeyre August 6, 2025 15:26
@nss10 nss10 removed the request for review from paulineribeyre August 7, 2025 14:50
@nss10 nss10 requested a review from paulineribeyre August 10, 2025 22:05
@nss10 nss10 requested a review from Avantol13 August 11, 2025 13:48
pyproject.toml Outdated
sqlalchemy = { extras = ["asyncio"], version = "<3" }
uvicorn = "<1"
cdispyutils = "^2.4.0"
cdispyutils = { git = "https://github.com/uc-cdis/cdis-python-utils.git", branch = "update_registry_in_constructors" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is temporary, until cdispyutils#72 is merged.

@nss10 nss10 requested a review from AJuehne-CTDS August 15, 2025 18:27
@nss10 nss10 changed the title Update Prometheus setup and /metrics endpoint Update Prometheus setup to prevent poetry install at every launch Aug 15, 2025
@nss10 nss10 merged commit a51cb91 into master Aug 18, 2025
8 checks passed
@nss10 nss10 deleted the chore/skip_poetry_install_at_launch branch October 6, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants