feat(profiles): simplify configuration and use standard .ini library,… #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow using --auth profile and getting api key from configuration
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
mfshao
reviewed
Nov 11, 2021
| from urllib.parse import urlsplit | ||
| from urllib.parse import parse_qs | ||
|
|
||
| CONFIG_FILE_PATH = expanduser("~/.gen3/config") |
Contributor
There was a problem hiding this comment.
fyi gen3-client has also been updated recently to adpot a standard .ini library for its config files, and the config file name has been changed in there https://github.com/uc-cdis/cdis-data-client/pull/104/files#diff-bd2e7cbbf1baffd3573ff07a2de731e31dca5ef335d98bd695d8ae4baea99c5eR26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… allow using --auth profile and getting api key from configuration
New Features
--auth profileto use that auth in any commandBreaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes