Skip non-udp and zero-user-length packets. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protoplas
force-pushed
the
minor
branch
2 times, most recently
from
e481ed1 to
9ca2ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a couple of segmentation faults. Re-ran the packet dumps with gdb and discovered that the segmentation faults were due to invalid memory accesses at the two places I've fixed in this PR.
getLayerOfType<UdpLayer>returns null sometimesMessageExtractoris sometimes 0, resulting in it becoming negative a few lines later and thenresizefailsIt's puzzling to me why this is happening, but the fix works for me.