Fix "secrets" directory creation in Nginx Proxy Manager installer #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dev mode, the nginxproxymanager installer could break if the "secrets" directory does not exist. It should be created regardless of dev mode; its path will just change based on which mode you're in. For example, when NOT in dev mode, the secrets directory is created at one of these: - ~/.nginxproxymanager/secrets - /etc/nginxproxymanager/secrets In dev mode, it will be in the project checkout: - proj/stacks/secrets
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the Nginx Proxy Manager installer when running in development mode by ensuring the "secrets" directory is created regardless of the installation mode.
- Moves the secrets directory creation outside of the production-only conditional block
- Ensures the secrets directory is created for both development and production installations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
akamal4
approved these changes
Sep 10, 2025
Contributor
akamal4
left a comment
akamal4
left a comment
There was a problem hiding this comment.
Approved, worked with out issue in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recently reinstalling Nginx Proxy Manager on one of my workstations, I decided to run it in dev mode to keep it local to my project, and I discovered that it crashed because of the "secrets" directory missing.
I discovered we should be creating the "secrets" directory regardless of dev install or not. This just fixes that.