Add IStorageProvider implementation based on IFileProvider#26
Draft
ronaldbarendse wants to merge 11 commits intodevelopfrom
Draft
Add IStorageProvider implementation based on IFileProvider#26ronaldbarendse wants to merge 11 commits intodevelopfrom
ronaldbarendse wants to merge 11 commits intodevelopfrom
Conversation
…P.NET Core IFileProvider
2 tasks
Contributor
Author
|
These are just some idea's that came up recently related to reworking the file providers:
|
|
Any chance this will continued? It seems related with an performance issue several users are experiencing in different versions of Umbraco (including 15). |
Just bumping this again as it is still a very big issue for anyone using Azure Blob Storage (Or S3 storage). The media section is very slow and for us often crashes the site when an editor goes there... We have added the temporary fix as mentioned, but would be nice with a more permanent fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds upon #11 (comment).
Instead of wrapping the media
IFileSystem(Umbraco's read/write IO abstraction) as anIFileProvider(ASP.NET Core read-only IO abstraction) to then use in theStaticFileMiddleware, this directly implements theIFileProviderfor the read-only part and exposes the write-operations in a newIStorageProviderabstraction.This is a POC and still needs a lot of work!