Possible improvements for TAXAassign#1
Open
frederic-mahe wants to merge 7 commits intoumerijaz:masterfrom
Open
Possible improvements for TAXAassign#1frederic-mahe wants to merge 7 commits intoumerijaz:masterfrom
frederic-mahe wants to merge 7 commits intoumerijaz:masterfrom
Conversation
That function could be replaced by mkdir -p anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Umer,
here are some coding style or simplifications I suggest for the TAXAassign shell script. Several of the conditional loops you use could be replace with one-liners ( [[test]] || die). Some tests regarding the status of files (exists, is empty, etc), could also be simplified by using the new pattern substitutions in bash 4.0. But unfortunately, many computer still have bash 3.0 installed.
Best,