Ejercicio API de perritos con su nombre y los tags de cada raza #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facu1391
approved these changes
May 27, 2023
Contributor
facu1391
left a comment
facu1391
left a comment
There was a problem hiding this comment.
Hola se puede ver un excelente trabajo! Podrías revisar mi PR?
cramdal
approved these changes
May 28, 2023
Contributor
cramdal
left a comment
cramdal
left a comment
There was a problem hiding this comment.
cumple con lo requerido, salvo la observación de los estilos.
Contributor
There was a problem hiding this comment.
Estos estilos al parecer no se están aplicando y hace que tus cards no se vean bien
lucianogarriga
approved these changes
Jun 8, 2023
Contributor
lucianogarriga
left a comment
lucianogarriga
left a comment
There was a problem hiding this comment.
Buenas, tu trabajo cumple con lo solicitado.
Asimismo, te realizo las siguientes recomendaciones:
- Colocar las instrucciones/consignas de la actividad en el archivo README.md de esta PR para que cualquiera que lea tu código sepa de que se trata.
- Los botones del navbar "atras" y "siguiente" no veo que tengan funcionalidad alguna, incluso viendo la consola desde el inspector de elementos no realiza nada.
- Como dice el compañero, parece que el archivo de estilos no se está tomando de manera correcta, para que se apliquen en el renderizado de las cards.
- Ver si se puede dar dinamismo a las propiedades del 'date' y 'readingTime' de cada card, así no quedan hardcodeadas.
- Consejo muy útil si puedes iniciar los proyectos siguiendo la metodología "First Mobile", ya que en la vista de dispositivos móviles las cards sobrepasan el vh de la pantalla.
Te agradezco si puedes pasar y revisar mi PR! Es la #15 Gracias!
Author
|
Dale yo reviso el tuyo |
MrRedu
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.