Skip to content

Fix input poll compatibility #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pemensik wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix input poll compatibility #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f0ddab
Fix input poll compatibility
pemensik Mar 7, 2021
025bf2d
Allow PWM.start() repeated calls
pemensik Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions RPi/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,8 +657,8 @@ def line_do_poll(channel, bouncetime, timeout):
break
if line_event_wait(channel, bouncetime, timeout):
callbacks = _State.lines[channel].callbacks
for fn in callbacks():
fn()
for fn in callbacks:
fn(channel)
end_critical_section(channel, msg="do poll")
time.sleep(TEN_MILLISECONDS_IN_SECONDS)

Expand Down Expand Up @@ -1166,6 +1166,7 @@ def __init__(self, channel, frequency):
if frequency <= 0.0:
raise ValueError("frequency must be greater than 0.0")
self.channel = channel
self.started = False
line_pwm_set_frequency(channel, frequency)

def start(self, dutycycle):
Expand All @@ -1176,13 +1177,16 @@ def start(self, dutycycle):
if dutycycle < 0.0 or dutycycle > 100.0:
raise ValueError("dutycycle must have a value from 0.0 to 100.0")

return line_pwm_start(self.channel, dutycycle)
if not self.started:
return line_pwm_start(self.channel, dutycycle)
return False

def stop(self):
"""
Stop software PWM
"""
line_pwm_stop(self.channel)
self.started = False

def ChangeDutyCycle(self, dutycycle):
"""
Expand All @@ -1199,7 +1203,6 @@ def ChangeFrequency(self, frequency):
Change the frequency
frequency - frequency in Hz (freq > 1.0)
"""

if frequency <= 0.0:
raise ValueError("frequency must be greater than 0.0")

Expand Down