Merged
Conversation
all of the othe containerfiles update the package list before installing to ensure that they install the latest versions.
We do not need envsubst at runtime or the unpopulated template. Have a build stage where where we create the homeserver.yaml and then copy only the final resulting file into the submatrix image
We can add our folder with the auth code to the list of places the module import code will look by putting a `.pth` file in the site-packages folder that has the correct path inside of it. The exact location this file goes depends on the python version, but python itself knows, so we can just use a one-liner to create the file with its contents in the appropriate place.
charliemirabile
force-pushed
the
submatrix_fixes
branch
from
37d10ac to
df6bfe4
Compare
theyoyojo
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
misc cleanups / opportunities for improvement discovered in submatrix while working on coverage code