standardize query order_by argument#271
Merged
charliemirabile merged 1 commit intomasterfrom Sep 29, 2025
Merged
Conversation
charliemirabile
requested changes
Aug 8, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
I agree that we should standardize, but I think that there are only 2 existing instances of .desc() vs the 4 instances of - that you are changing here. I would argue that maybe we should standardize in the other direction. While terse, I personally find the operator overloading syntax that peewee offers for construction queries to actually be one of the main advantages of using an ORM.
charliemirabile
force-pushed
the
master
branch
from
a073252 to
1a225dd
Compare
To sort the results of a query with peewee orm, in descending order,
we pass a column label to the order_by() method on a select() call
and either prefix it with the '-' symbol or call its.desc() method.
Currently we do some of both. Change all order_by({X.desc()} => {-X})
to make the code easier to read and more consistent.
Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
order_by_desc
branch
from
0b86b00 to
d045f5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To sort the results of a query with peewee orm, in descending order,
we pass a column label to the order_by() method on a select() call
and either prefix it with the '-' symbol or call its.desc() method.
Currently we do some of both. Change all order_by({X.desc()} => {-X})
to make the code easier to read and more consistent.