Merged
Conversation
We forgot to add dev_sockets.sh to list of scripts to be linted in script-lint.sh when it was introduced. Fixes: f063e49 ("container-compose: switch to unix sockets for nginx")
We forgot to add start.sh to list of scripts to be linted in script-lint.sh when it was introduced. Fixes: 0bbf8a3 ("orbit: Containerfile: move start command to script")
We forgot to add start.sh to list of scripts to be linted in script-lint.sh when we imported the CI code from circumference. Fixes: 930b740 ("CI: move code into singularity repo")
It is easy to forget to add scripts to script-lint.sh. Run a find command to search for any files ending in `.sh` and check how many are found against a known good count. This ensures that script lint will fail if a new script is added and it is not updated. This is not perfect since there are scipts like the githooks that do not have a .sh extension, but it should cover most cases and make it easy to do the right thing. Obviously it is concievable that a script might come along which we do not want to lint for some reason. In that case it is fine to just increment the number we check for without adding a call to shellcheck. It just makes sure that that choice is explicit.
charliemirabile
force-pushed
the
script_lint
branch
from
e29e223 to
9e6ad7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was fiddling with orbit start.sh when I got nerd sniped by the fact that we don't lint it and in fact there are several scripts that we added but forgot to lint. Restore order to the universe by adding them all, and try to make it harder to forget to add linting in the future.