Skip to content

Conversation

@unfunco
Copy link
Owner

@unfunco unfunco commented Nov 16, 2025

No description provided.

@unfunco unfunco requested a review from Copilot November 16, 2025 16:40
@unfunco unfunco self-assigned this Nov 16, 2025
@unfunco unfunco added the adds a feature 💡 Improvements or additions. label Nov 16, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for light and dark theme palettes with automatic detection based on terminal background color. The theme configuration structure has been refactored from a flat structure to separate dark and light palettes with a configurable mode setting.

  • Introduced three theme modes: auto (default), dark, and light for controlling palette selection
  • Refactored theme initialization to accept a hasDarkBackground parameter for automatic palette selection
  • Added comprehensive default palettes optimized for both light and dark backgrounds

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/config.json Updated test configuration to include separate dark and light palette definitions
main.go Modified theme initialization to detect terminal background and pass it to theme functions
internal/theme/theme_test.go Added test for auto mode light palette selection; updated existing tests for new Config structure
internal/theme/theme.go Added Mode type, PaletteConfig struct, and logic for palette selection; refactored theme creation to support multiple palettes
internal/config/config_test.go Updated config tests to validate new nested theme structure
README.md Added documentation section explaining theme configuration and mode options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@unfunco unfunco merged commit a5618ba into main Nov 16, 2025
7 checks passed
@unfunco unfunco deleted the feat/light-dark-themes branch November 16, 2025 16:51
@github-actions github-actions bot mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adds a feature 💡 Improvements or additions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants