Skip to content

Add filter to address bar #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zamuzakki wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add filter to address bar #387

zamuzakki wants to merge 6 commits into from

Conversation

@zamuzakki
Copy link
Collaborator

@zamuzakki zamuzakki commented Jan 29, 2025

This is draft PR for https://github.com/unicef-drp/GeoSight/issues/431

I will add E2E tests after discussing whether this is the correct approach once @meomancer is back

@zamuzakki zamuzakki requested a review from meomancer January 29, 2025 04:40
meomancer
meomancer reviewed Jan 30, 2025
View reviewed changes
@zamuzakki zamuzakki marked this pull request as ready for review January 31, 2025 01:14
@meomancer
Copy link
Collaborator

meomancer commented Feb 10, 2025

Hi @zamuzakki

  • Please make sure it does not call multiple time at first load
    Selection_050

  • Make sure the url does not append on non list page
    Selection_051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meomancer meomancer meomancer left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zamuzakki @meomancer