feat: configFile: false to disable config file loading#245
Open
feat: configFile: false to disable config file loading#245
configFile: false to disable config file loading#245Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 76.92% 77.79% +0.87%
==========================================
Files 7 6 -1
Lines 806 635 -171
Branches 80 124 +44
==========================================
- Hits 620 494 -126
+ Misses 184 141 -43
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
configFile: falseconfigFile: false to disable config file loading
Member
|
Thanks for the time on this PR. PR looks nice, but I'm a little bit hesitant if it adds real value vs internal complexity. |
Member
Author
Reasonable concern. We can just hold off on it until more users/real cases require this. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #236
This PR brings back support for
configFile: false.