feat(docker): disable containers page file modification

[pujitm]

Summary

• Disables the Docker containers page file modification by always returning shouldApply: false
• This effectively turns off the Docker overview table modification feature

Test plan

• Verify the API builds successfully
• Confirm the Docker containers page modification is no longer applied on Unraid servers

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor
  • Disabled Docker containers page modification feature.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A single file modification removes conditional gating logic from a Docker containers page modification class. The shouldApply method, which previously checked an ENABLE_NEXT_DOCKER_RELEASE flag with version-specific auto-enabling, now unconditionally returns false.

Changes

Cohort / File(s)	Summary
Docker Containers Modification Gating api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts	Removed ENABLE_NEXT_DOCKER_RELEASE import and associated conditional logic from shouldApply() method; method now unconditionally returns false with empty reason. Patch generation and source modification behavior unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A gate once stood, with flags held high,
Checking versions 'neath the sky,
But simpler paths are best, we say—
False it stands, to block the way! 🚫✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and accurately summarizes the main change: disabling the Docker containers page file modification. It directly relates to the changeset where shouldApply now always returns false.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.43%. Comparing base (38a6f0c) to head (16c45a4).

Files with missing lines	Patch %	Lines
...difications/docker-containers-page.modification.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   46.40%   46.43%   +0.02%     
==========================================
  Files         954      954              
  Lines       59791    59774      -17     
  Branches     5538     5538              
==========================================
+ Hits        27749    27754       +5     
+ Misses      31923    31901      -22     
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1870/dynamix.unraid.net.plg

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts (1)

20-40: Consider removing unreachable code (optional).

Since shouldApply always returns false, the generatePatch and applyToSource methods are now unreachable. If this change is permanent, consider removing these methods to reduce maintenance burden. If this is a temporary disable and the feature may be re-enabled, keeping them is reasonable.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38a6f0c and 16c45a4.

📒 Files selected for processing (1)

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx}: Always use TypeScript imports with .js extensions for ESM compatibility
Never add comments unless they are needed for clarity of function
Never add comments for obvious things, and avoid commenting when starting and ending code blocks

Files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

api/**/*

📄 CodeRabbit inference engine (CLAUDE.md)

Prefer adding new files to the NestJS repo located at api/src/unraid-api/ instead of the legacy code

Files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Never use the any type. Always prefer proper typing
Avoid using casting whenever possible, prefer proper typing from the start

Files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

api/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

cache-manager v7 expects TTL values in milliseconds, not seconds (e.g., 600000 for 10 minutes, not 600)

Files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

**/*

📄 CodeRabbit inference engine (.cursor/rules/default.mdc)

Never add comments unless they are needed for clarity of function

Files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

🧠 Learnings (2)

📚 Learning: 2025-01-29T16:35:43.699Z

Learnt from: elibosley
Repo: unraid/api PR: 1082
File: api/src/unraid-api/unraid-file-modifier/modifications/log-rotate.modification.ts:39-41
Timestamp: 2025-01-29T16:35:43.699Z
Learning: In the Unraid API, FileModification implementations (apply/rollback methods) don't need to implement their own error handling as it's handled by the UnraidFileModifierService caller.

Applied to files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

📚 Learning: 2025-04-21T18:44:39.643Z

Learnt from: elibosley
Repo: unraid/api PR: 1352
File: packages/unraid-api-plugin-connect/src/config.persistence.ts:0-0
Timestamp: 2025-04-21T18:44:39.643Z
Learning: When working with file operations in Node.js, prefer using the native Promise-based APIs from the fs/promises module instead of callback-based APIs from fs or manually wrapping callbacks in Promises.

Applied to files:

• api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts

🔇 Additional comments (2)

api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts (2)

13-18: LGTM! Feature successfully disabled.

The shouldApply method now unconditionally returns false, which achieves the stated objective of disabling the Docker containers page modification.

---

8-18: No breaking dependencies found. The modification will be dynamically discovered by UnraidFileModificationService but safely disabled since shouldApply() returns false. No other code references the class by name or depends on this modification applying.