Skip to content

[AIR-3036] qs: combine argContainsGithubIssueLink() and GetJiraTicketIDFromArgs() funcs#134

Merged
host6 merged 3 commits intountillpro:mainfrom
host6:AIR-3036-qs-combine-argContainsGithubIssueLink-and-GetJiraT-pr
Feb 23, 2026
Merged

[AIR-3036] qs: combine argContainsGithubIssueLink() and GetJiraTicketIDFromArgs() funcs#134
host6 merged 3 commits intountillpro:mainfrom
host6:AIR-3036-qs-combine-argContainsGithubIssueLink-and-GetJiraT-pr

Conversation

@host6
Copy link
Collaborator

@host6 host6 commented Feb 23, 2026

AIR-3036 qs: combine argContainsGithubIssueLink() and GetJiraTicketIDFromArgs() funcs
https://untill.atlassian.net/browse/AIR-3036

@augmentcode
Copy link

augmentcode bot commented Feb 23, 2026

🤖 Augment PR Summary

Summary: This PR centralizes “issue” detection (GitHub vs Jira vs free-form) into a single helper to simplify the dev-branch creation flow.

Changes:

  • Refactored internal/commands/dev.go to call issue.ParseIssueFromArgs and switch on a typed IssueType instead of running separate GitHub/Jira detectors.
  • Removed the local GitHub issue URL parsing/validation helpers (argContainsGithubIssueLink, checkIssueLink) from dev.go.
  • Added new internal/issue package with IssueInfo / IssueType and GitHub validation via gh issue view.
  • Added table-driven unit tests for ParseIssueFromArgs.
  • Archived related uspec change docs under uspecs/changes/archive/….

Technical Notes: GitHub issue links are validated by executing the GitHub CLI in the working directory; Jira detection reuses jira.GetJiraTicketIDFromArgs.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@host6 host6 merged commit 73e6cc2 into untillpro:main Feb 23, 2026
0 of 3 checks passed
@host6 host6 deleted the AIR-3036-qs-combine-argContainsGithubIssueLink-and-GetJiraT-pr branch February 23, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant