Skip to content

feat: add GlobeControl to preview map. #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smellman merged 2 commits into from
Aug 5, 2025
Merged

feat: add GlobeControl to preview map. #203

smellman merged 2 commits into from
Aug 5, 2025

Conversation

@JinIgarashi
Copy link
Member

@JinIgarashi JinIgarashi commented Aug 5, 2025

Thank you for submitting a pull request!

Description

  • added GlobeControl of maplibre-gl-js to serve command preview map.
  • globe mode might be useful if users want to check stying in globe other than standard mercator.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the existing features working well
  • Have you added at least one unit test if you are going to add new feature?
  • Have you updated documentation?

Refer to CONTRIBUTING.MD for more details.

@JinIgarashi JinIgarashi added the enhancement New feature or request label Aug 5, 2025
@JinIgarashi JinIgarashi requested a review from smellman August 5, 2025 06:27
smellman
smellman requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@smellman smellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one line comment.

provider/src/main.ts Outdated
}),
)
map.addControl(new NavigationControl(), 'top-right')
map.addControl(new NavigationControl({}), 'top-right')
Copy link
Contributor

@smellman smellman Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line's diff needed?

Copy link
Member Author

@JinIgarashi JinIgarashi Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried to add some options of NavigationControl to see how it looks like. I forgot to delete it.
Now I removed.

@JinIgarashi JinIgarashi requested a review from smellman August 5, 2025 06:38
smellman
smellman approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@smellman smellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smellman smellman merged commit e0ecc71 into unvt:main Aug 5, 2025
4 checks passed
@JinIgarashi JinIgarashi deleted the feat/add-globecontrol branch August 5, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smellman smellman smellman approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JinIgarashi @smellman