Centralize generic forms toast feedbacks in OSS Components #615
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olxmpe
changed the title
Contributor
Elodie-DeMatteis-Upf
left a comment
Elodie-DeMatteis-Upf
left a comment
There was a problem hiding this comment.
As this is an OSS PR, you should add some clear description in the PR
Miexil
approved these changes
Jan 9, 2026
phndiaye
approved these changes
Jan 9, 2026
Elodie-DeMatteis-Upf
approved these changes
Jan 9, 2026
aprentout
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We use the same wording for generic form validation toasts across Upfluence ecosystem. Those translations are now each under a single translation key in OSS components to make forms more maintenable :
'generic'success message'requirement'error when fields are misssing'format'error when format is invalid'format_and_requirement'when bothRelated to: #6487
What are the observable changes?
Good PR checklist