OSS::Sidebar::Item: Do not display icon div when no icon is provided #616
+202
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elodie-DeMatteis-Upf
changed the base branch from
master
to
feature/improve-settings-navigation
Elodie-DeMatteis-Upf
force-pushed
the
edm/vel-6692
branch
from
3035821 to
4893d11
Compare
[Wizard] Improve scroll behavior
…scrollbar Remove scrollbar styles
…vigation-arrow-improvement Update positions for the previous / next button of OSS::Caroussel
Add action arg to OSS::Layout::Sidebar::Item
Elodie-DeMatteis-Upf
force-pushed
the
edm/vel-6692
branch
from
4893d11 to
7bb975c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The optional arg
iconwas always used even when not provided. This PR hides the empty icon div when no icon is provided, and adapts the corresponding style. It fixes an error that would occur if no icon was provided, as it tried to render anOSS::Iconwith an undefined icon.Related to: #
What are the observable changes?
"Visual" tab without icon
Selected
Hovered
Good PR checklist