SQL basics - RDBMS and its features.#1817
SQL basics - RDBMS and its features.#1817dheerajsn2004 wants to merge 1 commit intoupgrad-edu:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the course notes repository by adding a new learner/module entry to Course1, but also introduces IntelliJ/IDEA project configuration files that are typically not intended for version control.
Changes:
- Added a new entry (name + module learnings) to
Course1. - Added multiple
.idea/IDE configuration files to the repository.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
Course1 |
Adds a new learner entry and module learnings. |
.idea/vcs.xml |
Adds IDE VCS mapping configuration (likely should not be committed). |
.idea/modules.xml |
Adds IDE module configuration (likely should not be committed). |
.idea/misc.xml |
Adds IDE project/JDK settings (likely should not be committed). |
.idea/Upgrad.iml |
Adds IDE module file (likely should not be committed). |
.idea/.gitignore |
Adds IDEA-local ignores, but doesn’t address committing .idea/ files overall. |
Files not reviewed (5)
- .idea/.gitignore: Language not supported
- .idea/Upgrad.iml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/modules.xml: Language not supported
- .idea/vcs.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module type="JAVA_MODULE" version="4"> | ||
| <component name="NewModuleRootManager" inherit-compiler-output="true"> | ||
| <exclude-output /> | ||
| <content url="file://$MODULE_DIR$" /> | ||
| <orderEntry type="inheritedJdk" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| </component> | ||
| </module> No newline at end of file |
There was a problem hiding this comment.
These IntelliJ/IDEA project files are machine- and developer-specific and typically shouldn't be committed to the repository. Please remove this file from the PR and add a root-level .gitignore entry to ignore .idea/ (and *.iml) going forward.
| # Default ignored files | ||
| /shelf/ | ||
| /workspace.xml |
There was a problem hiding this comment.
Adding .idea/.gitignore doesn't prevent committing other .idea files that are already in the PR. Prefer adding a repository root .gitignore entry for .idea/ (and *.iml) and remove the committed IDE config files from version control.
| # Default ignored files | |
| /shelf/ | |
| /workspace.xml | |
| # Intentionally left blank. | |
| # IDE files should be ignored via the repository root .gitignore (e.g. .idea/ and *.iml). |
| Dheeraj S N | ||
| RDBMS and its | ||
| 1) Learnt about the features of RDBMS. | ||
| 2) Learnt the importance of Normalization while structuring the database. | ||
| 3) Learnt about ER diagrams |
There was a problem hiding this comment.
The added module entry doesn't match the module list at the top of this file (Algorithm Analysis / Divide and Conquer / Dynamic Programming). Please either select one of the listed modules for Course1 or update the course template/module list so the new entry is consistent.
| Understanding the prolem and implementing a solution which is space and time efficient by structuring it into sub problems. | ||
|
|
||
| Dheeraj S N | ||
| RDBMS and its |
There was a problem hiding this comment.
The module name "RDBMS and its" looks truncated/incomplete. Consider updating it to the full module/title (e.g., "RDBMS and its features") so the entry reads clearly.
| RDBMS and its | |
| RDBMS and its features |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="VcsDirectoryMappings"> | ||
| <mapping directory="" vcs="Git" /> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
These IntelliJ/IDEA project files are machine- and developer-specific and typically shouldn't be committed to the repository. Please remove this file from the PR and add a root-level .gitignore entry to ignore .idea/ (and *.iml) going forward.
| <?xml version="1.0" encoding="UTF-8"?> | |
| <project version="4"> | |
| <component name="VcsDirectoryMappings"> | |
| <mapping directory="" vcs="Git" /> | |
| </component> | |
| </project> |
| <project version="4"> | ||
| <component name="ProjectModuleManager"> | ||
| <modules> | ||
| <module fileurl="file://$PROJECT_DIR$/.idea/Upgrad.iml" filepath="$PROJECT_DIR$/.idea/Upgrad.iml" /> | ||
| </modules> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
These IntelliJ/IDEA project files are machine- and developer-specific and typically shouldn't be committed to the repository. Please remove this file from the PR and add a root-level .gitignore entry to ignore .idea/ (and *.iml) going forward.
| <project version="4"> | |
| <component name="ProjectModuleManager"> | |
| <modules> | |
| <module fileurl="file://$PROJECT_DIR$/.idea/Upgrad.iml" filepath="$PROJECT_DIR$/.idea/Upgrad.iml" /> | |
| </modules> | |
| </component> | |
| </project> | |
| <!-- | |
| IntelliJ IDEA project configuration was removed from version control. | |
| This file is intentionally left minimal; .idea/ and *.iml should be ignored via .gitignore. | |
| --> |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="ProjectRootManager" version="2" languageLevel="JDK_17" default="true" project-jdk-name="corretto-17" project-jdk-type="JavaSDK"> | ||
| <output url="file://$PROJECT_DIR$/out" /> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
These IntelliJ/IDEA project files are machine- and developer-specific and typically shouldn't be committed to the repository. Please remove this file from the PR and add a root-level .gitignore entry to ignore .idea/ (and *.iml) going forward.
| <?xml version="1.0" encoding="UTF-8"?> | |
| <project version="4"> | |
| <component name="ProjectRootManager" version="2" languageLevel="JDK_17" default="true" project-jdk-name="corretto-17" project-jdk-type="JavaSDK"> | |
| <output url="file://$PROJECT_DIR$/out" /> | |
| </component> | |
| </project> | |
| <!-- Intentionally left blank. | |
| IntelliJ IDEA project configuration should not be committed to version control. | |
| This file is retained only as an empty placeholder. --> |
1 participant
My name is Dheeraj S N.
So I modified the contents in the Course1 file.
I added my Name, a module name and things I learnt in that module.