dpu: lldb: Explicitly handle errors when looking up error_storage var…#67
Open
aharries-upmem wants to merge 2 commits intoupmem_release_120from
Open
dpu: lldb: Explicitly handle errors when looking up error_storage var…#67aharries-upmem wants to merge 2 commits intoupmem_release_120from
aharries-upmem wants to merge 2 commits intoupmem_release_120from
Conversation
dlagneux-upmem
approved these changes
Aug 12, 2022
| error_store_addr_ptr) | ||
| .ToError(); | ||
| } else { | ||
| return Status("Recieved null pointer from UPMEM_LLDB_ERROR_STORE_ADDR " |
There was a problem hiding this comment.
Suggested change
| return Status("Recieved null pointer from UPMEM_LLDB_ERROR_STORE_ADDR " | |
| return Status("Received null pointer from UPMEM_LLDB_ERROR_STORE_ADDR " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iable