Merged
Conversation
cdnsyseng
requested changes
Jan 29, 2026
fw42
reviewed
Jan 29, 2026
Contributor
fw42
left a comment
fw42
left a comment
There was a problem hiding this comment.
I think some of these tests could have stronger assertions, but in general I like this idea. Maybe at some point in the future we could even consider running the python integration tests against a locally running urlscan on CI. But we're a bit far away from that.
Co-authored-by: cdnsyseng <hal@urlscan.io>
Co-authored-by: cdnsyseng <hal@urlscan.io>
cdnsyseng
approved these changes
Jan 30, 2026
fw42
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests and also fix an issue found through them.
tests/unitandtests/integration