Skip to content

Conversation

@SwampertX
Copy link
Collaborator

@SwampertX SwampertX commented Jul 14, 2019

This PR will add a second bus timing to the display

Description

problems:

  • if a bus has no service, the bus service number is prepended with the word "bus" which is out of place
  • there is a possibility that there is a first bus, but no subsequent ones. this case is not handled
  • better still, write test cases

Motivation and Context

Currently you can only see the eta for the next incoming public bus. Since the API provides 3 timings, we could use a second one :)

How Has This Been Tested?

Nope, we are yet to set up testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants