Merged
Conversation
… formatting, reuse ignore crate 1. Removed hand-rolled glob_match() in favor of the `ignore` crate's Gitignore matcher — same API used by rpg-encoder's evolution.rs for .rpgignore handling. Added `ignore` as a dependency to rpg-nav. 2. Extracted ~130 lines of inline TOON formatting from the detect_cycles tool handler in tools.rs into format_cycle_report() in toon.rs, matching the existing format_health_report() pattern. 3. Replaced CycleConfig's project_root + ignore_rpgignore fields with a single excluded_paths: Option<Gitignore>, moving .rpgignore loading responsibility to the MCP layer where it belongs. Closes #62 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glob_match()withignore::gitignore::Gitignore— same API used byrpg-encoder/src/evolution.rsfor.rpgignorehandlingdetect_cyclestool handler intoformat_cycle_report()intoon.rs, matching theformat_health_report()patternCycleConfig'sproject_root+ignore_rpgignorefields withexcluded_paths: Option<Gitignore>, moving.rpgignoreloading to the MCP layerCloses #64
Test plan
cargo build --workspacepassescargo build --workspace --no-default-featurespasses (ARM64 path)cargo clippy --workspace --all-targets -- -D warningscleancargo fmt --all -- --checkcleancargo test --workspace— all tests pass🤖 Generated with Claude Code