This repository was archived by the owner on Apr 28, 2024. It is now read-only.
Partial caching support, backward compatible #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this required for 4.4.0 ? |
Member
Author
|
Nope |
lcharette
approved these changes
Apr 11, 2020
Member
lcharette
left a comment
lcharette
left a comment
There was a problem hiding this comment.
I didn't test, but code looks ok.
Member
|
@Silic0nS0ldier If you want to merge this, go ahead. Just need to fix those conflict first :) |
Member
Author
|
Awesome, I'll at this to my list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had wanted to add better caching in, but I discovered doing so would attract breaking changes. The implementation here should at least take some heat off dev hosting scenarios by ending requests sooner (less time in IO).
CI has also been switched over to Github Actions, however I wasn't able to complete the migration. The codecov secret needs to be added and the respective step uncommented. Appveyor integration will need to be removed.