Remove unused initial value in Writer/File.ts writeImplementation#12
Merged
Remove unused initial value in Writer/File.ts writeImplementation#12
Conversation
Merged
Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on refactoring to version 2
Remove unused initial value in Writer/File.ts writeImplementation
Nov 6, 2025
simonmika
added a commit
that referenced
this pull request
Nov 6, 2025
* Updated configuration. * Further cleanup. * Fixed compile issues. * Fixed remaining compile issues. * Renamed test files. * Full verification suite works. * Breaking change, changed from isEmpty to empty. * Modernized exports. * Fixed remaining export import issues. * Improved structure of Uri class. * Improved Error. * Fixed String. * Removed String as it did not add significant value. * Fixed Enumerator exports. * Fixed file name of Enumerator. * Fixed Device naming. * Refactored Reader and Writer. * Fix fs.write signature to use string overload instead of Buffer (#11) * Initial plan * Fix fs.write signature to use string overload with utf8 encoding Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> * Remove unused initial value in Writer/File.ts writeImplementation (#12) * Initial plan * Fix unused initial value in Writer/File.ts writeImplementation Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> * Fixed issues with fs.write signatures. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> Co-authored-by: Simon Mika <simonmika@users.noreply.github.com> Co-authored-by: Simon Mika <simon@mika.se> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on #10 regarding an unused initial value in the
writeImplementationmethod.Changes
truevalue fromresultvariable inWriter/File.ts:40let result = truetolet result: booleanThe initial value was unnecessary since
resultis always assigned in both the try block (r.bytesWritten == content.length) and catch block (false) before being read.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.