-
Notifications
You must be signed in to change notification settings - Fork 81
Improve javasteam memory handling, 1.8.1-SNAPSHOT #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated javasteam version from 1.8.0-SNAPSHOT to 1.8.1-SNAPSHOT.
📝 WalkthroughWalkthroughThis pull request updates the javasteam library dependency version from 1.8.0-SNAPSHOT to 1.8.1-SNAPSHOT in the Gradle version catalog. The artifact coordinate remains unchanged, with no impact on other dependencies or functional behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
gradle/libs.versions.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
| feature-delivery = "2.1.0" # https://mvnrepository.com/artifact/com.google.android.play/feature-delivery | ||
| hiltNavigationCompose = "1.2.0" # https://mvnrepository.com/artifact/androidx.hilt/hilt-navigation-compose | ||
| javasteam = "1.8.0-SNAPSHOT" # https://mvnrepository.com/artifact/in.dragonbra/javasteam | ||
| javasteam = "1.8.1-SNAPSHOT" # https://mvnrepository.com/artifact/in.dragonbra/javasteam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
javasteam 1.8.1-SNAPSHOT maven repository
💡 Result:
I couldn't find a published 1.8.1-SNAPSHOT for JavaSteam in any public Maven snapshot repository. JavaSteam (groupId in.dragonbra) releases are on Maven Central (latest published versions visible there), and the project source is on GitHub if you need to build a snapshot yourself. [1][2]
Links:
- JavaSteam on Maven Central (artifact listings). [1]
- JavaSteam GitHub repository (build from source / check CI for snapshot publishing). [2]
If you want, I can:
- check the repo's GitHub Actions/workflows for any snapshot publishing destination, or
- give exact Maven coordinates and steps to build and install 1.8.1-SNAPSHOT locally.
🏁 Script executed:
# Check Maven Central and Snapshot repositories for javasteam version
echo "=== Checking Maven Central for javasteam versions ==="
curl -s "https://central.sonatype.dev/api/v1/search?q=javasteam&limit=10" | python3 -m json.tool 2>/dev/null | head -50
echo ""
echo "=== Checking Sonatype Snapshot repository for 1.8.1-SNAPSHOT ==="
curl -s "https://oss.sonatype.org/content/repositories/snapshots/in/dragonbra/javasteam/" 2>/dev/null | grep -i "1.8.1" || echo "No snapshot found via direct listing"Repository: utkarshdalal/GameNative
Length of output: 153
🏁 Script executed:
# Check GitHub repository for recent releases and version info
echo "=== GitHub API: Recent tags/releases for JavaSteam ==="
curl -s "https://api.github.com/repos/Longi94/JavaSteam/releases?per_page=10" | python3 << 'EOF'
import json
import sys
try:
data = json.load(sys.stdin)
if data:
for release in data[:5]:
print(f"Tag: {release['tag_name']}, Draft: {release['draft']}, Prerelease: {release['prerelease']}, Published: {release['published_at']}")
else:
print("No releases found")
except:
print("Error parsing response")
EOF
echo ""
echo "=== GitHub API: Recent commits ==="
curl -s "https://api.github.com/repos/Longi94/JavaSteam/commits?per_page=5" | python3 << 'EOF'
import json
import sys
try:
data = json.load(sys.stdin)
for commit in data[:5]:
message = commit['commit']['message'].split('\n')[0]
sha = commit['sha'][:7]
print(f"{sha} - {message}")
except:
print("Error parsing commits")
EOFRepository: utkarshdalal/GameNative
Length of output: 153
🏁 Script executed:
# Check gradle build files for repository configuration
echo "=== Gradle settings and build files ==="
find . -name "build.gradle*" -o -name "settings.gradle*" -o -name "gradle.properties" | head -20
echo ""
echo "=== Repository configuration in gradle files ==="
fd -e "gradle" | xargs grep -l "repositories\|snapshot" | head -10Repository: utkarshdalal/GameNative
Length of output: 268
🏁 Script executed:
# Check if there are any CI workflows that publish snapshots
echo "=== CI workflow files ==="
find . -path "*/.github/workflows/*" -o -path "*/.gitlab-ci.yml" -o -path "*/azure-pipelines.yml" 2>/dev/null | head -20
if [ -d ".github/workflows" ]; then
echo ""
echo "=== GitHub Actions workflow files ==="
ls -la .github/workflows/ 2>/dev/null | grep -v "^total"
echo ""
echo "=== Checking for snapshot publishing in workflows ==="
grep -r "snapshot\|publish" .github/workflows/ 2>/dev/null | head -20
fiRepository: utkarshdalal/GameNative
Length of output: 620
🏁 Script executed:
# Check javasteam dependency declarations and build configuration
echo "=== Examining gradle/libs.versions.toml context ==="
cat gradle/libs.versions.toml | head -80Repository: utkarshdalal/GameNative
Length of output: 7731
The 1.8.1-SNAPSHOT version of javasteam is not available in any public Maven repository and cannot be resolved.
This version does not exist in Maven Central or any standard Sonatype snapshot repositories. Additionally, no custom snapshot repository is configured in the project's Gradle files, and no snapshot publishing is set up in CI workflows. The build will fail during dependency resolution.
Either:
- Update to an available stable version (e.g.,
1.8.0if it exists on Maven Central) - Configure a custom snapshot repository if this snapshot is published internally
- Build and publish the snapshot before merging this PR
🤖 Prompt for AI Agents
In gradle/libs.versions.toml around line 14 the dependency version javasteam =
"1.8.1-SNAPSHOT" cannot be resolved from public Maven repos; replace it with a
published stable version (for example "1.8.0") by updating that entry, or if the
SNAPSHOT is required configure the project to use the internal/custom snapshot
repository (add its URL and credentials to Gradle settings and repositories) or
publish the 1.8.1-SNAPSHOT to the snapshot repository used by CI before merging;
ensure the chosen approach is applied consistently across all Gradle files and
CI publishing/configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.8.1-SNAPSHOT exists through maven central.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== Verifying 1.8.1-SNAPSHOT existence ==="
curl -s "https://central.sonatype.com/repository/maven-snapshots/in/dragonbra/javasteam/1.8.1-SNAPSHOT/maven-metadata.xml" | head -30
echo ""
echo "=== Checking Gradle repository configuration ==="
# Check settings.gradle or settings.gradle.kts for repository configuration
if [ -f "settings.gradle" ]; then
echo "--- settings.gradle ---"
cat settings.gradle
fi
if [ -f "settings.gradle.kts" ]; then
echo "--- settings.gradle.kts ---"
cat settings.gradle.kts
fi
echo ""
echo "=== Checking build.gradle files for repository configuration ==="
fd -e gradle -e kts | xargs grep -A5 -B2 "repositories\s*{" | head -100
Length of output: 2692
@LossyDragon, you're absolutely right, and I apologize for the incorrect analysis.
I've verified that:
- ✅ The
1.8.1-SNAPSHOTdoes exist - The maven-metadata.xml confirms it was published today (2025-12-29 16:17:58) with build number 2 - ✅ The snapshot repository is already configured - Your
settings.gradle.kts(line 17) includes:maven { url = uri("https://central.sonatype.com/repository/maven-snapshots/") } // JavaSteam
The dependency will resolve correctly, and the build should work without any issues. Thank you for the correction!
Updated javasteam version from 1.8.0-SNAPSHOT to 1.8.1-SNAPSHOT.
Improved memory handling, related PR: Longi94/JavaSteam#377
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.