netsync, wire, chaincfg: don't ask for targets #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since wire.TTLInfo contains all the information we need to sort the ttls to targets at the given blocks, we which to use them directly instead of having a type defined.
Since the ttls can be used to calculate the targets, don't ask for the targets when we're able to download the ttls.
The UtreexoTTLCache will process and keep track of any leaves that should be cached and will return getutreexoproof messages based on the leaves it has cached. This replaces all other bits of caches that exist in other parts of the codebase as of this commit.
Since we'll be using the UtreexoTTLCache, we no longer have to communicate the ttl data. Rather we now have to communicate the processed data thus we add addLeaves and uncacheHashes.
Instead of keeping track of the ttls in the sync manager, we now delegate that role to the utreexo ttl cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're able to generate the targets from the ttls, we don't ask for them
if we're still downloading ttls.