This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Switched running the tests to the default industrial_ci test runner. #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it necessary to run the tests explicitly with the run_tests.sh shell script? I have changed running the tests to the default industrial_ci test runner. The tests seem to run just fine. I think this PR is necessary, because catkin_tools is not released for Ubuntu 20.04, yet. In my opinion, even if catkin_tools will be released it is more future proof to just let industrial_ci handle running the tests.
I have also removed running the before_script. It would install catkin_tools, which is not needed anymore and other stuff, which is not needed at all in the build pipeline.
If this PR will be merged it might make sense to delete the unused shell scripts. However, it might also make sense keep them, to be able to quickly setup uuv_simulator locally.