Open
Conversation
nilsnolde
commented
Jan 31, 2026
| cyclelane: cyclelaneNames, | ||
| sac_scale: sacScaleNames, | ||
| node_type: nodeTypeNames, | ||
| type: nodeTypeNames, |
Member
Author
There was a problem hiding this comment.
this was actually a tiny bug
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/329 |
nilsnolde
requested review from
chrstnbwnkl and
mustaphaturhan
and removed request for
chrstnbwnkl
mustaphaturhan
approved these changes
Feb 2, 2026
Member
Author
|
@chrstnbwnkl what do you think about the UX/logic? you're probably the only other person actively using the tile tab other than me |
chrstnbwnkl
reviewed
Feb 2, 2026
| } else if ( | ||
| typeof value == 'number' && | ||
| key.includes('speed') && | ||
| (value == 0 || value == 254) |
Member
There was a problem hiding this comment.
value == 254 would also hide e.g. breakpoint2 == 254 which could be valid right?
Member
There was a problem hiding this comment.
since it has the key live_speed:<dir>:breakpoint2
chrstnbwnkl
approved these changes
Feb 2, 2026
Member
chrstnbwnkl
left a comment
chrstnbwnkl
left a comment
There was a problem hiding this comment.
looks good, maybe address this minor comment on live speed breakpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying out #328 for feedback.
wdyt?