-
Notifications
You must be signed in to change notification settings - Fork 4
Improve navigation for Python API and Public REST API — DO NOT MERGE #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Going to take a closer look, but I don't like this:
I massaged the footer into the three columns initially because the two columns looked un-equal and cramped. Can we please revert? Your columns are actually also missing a link! (Access) |
…nd hide .nav-footer-center before getting cut off
The top and bottom padding seems a little squished as well, I tried to poke around in it but admittedly I haven't spent much time with the footer so I'm not sure if I'm looking in the right place... 🤔 |
|
@nrichers I think the last CSS PR mucked up the link styling as well . . .
Can you please look into a fix in this PR? |
Yes, I will take a look. (Currently in product feature description hell but will take a look as soon as I can!) EDIT: the CSS I looked at was unrelated, ignore. |
sc-12329/add-public-api-to-footer
I would hold off on poking around; I'm four hours deep into the footer CSS. Might be easier for you to just review my changes when they are ready. |
@validbeck I figured it out in b8d5127:
The fix is to set the link color the way Quarto intended and not to immediately resort to overriding the theme. But note is some other CSS affected, will take a look when I have a chance:
|
|
@validbeck one other thing before I re-request review from you: there are some specificity differences when you use SCSS versus |
validbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links still don't quite look right on hover:
| OLD | CURRENT |
|---|---|
![]() |
![]() |
In this case I personally like the new non-underlined link better, but having an underline somewhere in the link interaction process is a good accessibility tool . . .
Footer has all the stuff (I think) but the top and bottom padding is still really squished. For example:
| OLD | CURRENT |
|---|---|
![]() |
![]() |
I tried playing around with it locally but nothing I did to the padding seems to have adjusted anything, so I'm not sure how that's all working.
This is fixed in 0b1007d:
This should be fixed in 78b5e8c and 175c4e8: Capto_.2025-09-26_10-40-18_am.movWith all of these issues, the correct approach that gives most fine-grained control seems to be:
|
PR SummaryThis PR introduces extensive refinements to the styling and theme configuration of the website. The changes unify color usage by replacing hard-coded color values with Sass variables (e.g., for buttons, navbar, sidebar, code blocks, and other elements) to promote consistency with the ValidMind brand. Key changes include:
The functional changes are strictly related to presentation and navigation improvements, without affecting underlying business or application logic. Test Suggestions
|
Vale source linterShow first 30 files with issuessite/404.qmd
site/about/contributing/style-guide/conventions.qmd
site/about/contributing/style-guide/style-guide.qmd
site/about/contributing/style-guide/voice-and-tone.qmd
site/about/contributing/validmind-community.qmd
site/about/deployment/_deployment-available-options.qmd
site/about/deployment/deployment-options.qmd
site/about/deployment/multi-tenant-cloud.qmd
site/about/deployment/virtual-private-validmind.qmd
site/about/fine-print/data-privacy-policy.qmd
site/about/fine-print/license-agreement.qmd
site/about/glossary/_ai.qmd
site/about/glossary/_attestation.qmd
site/about/glossary/_developer-tools.qmd
site/about/glossary/_model-documentation.qmd
site/about/glossary/_models.qmd
site/about/glossary/_monitoring.qmd
site/about/glossary/_mrm.qmd
site/about/glossary/_validation-reports.qmd
site/about/glossary/_validmind-features.qmd
site/about/glossary/_validmind.qmd
site/about/glossary/glossary.qmd
site/about/glossary/key_concepts/_docs.qmd
site/about/glossary/key_concepts/_inputs.qmd
site/about/glossary/key_concepts/_key-concepts.qmd
site/about/glossary/key_concepts/_metrics.qmd
site/about/glossary/key_concepts/_monitoring-template.qmd
site/about/glossary/key_concepts/_outputs.qmd
site/about/glossary/key_concepts/_parameters.qmd
site/about/glossary/key_concepts/_template.qmd
... and 653 more files with issues |
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
|
As per @validbeck in #966:
|














Pull Request Description
THIS PR NEEDS FURTHER TESTING AND CHANGES BEFORE WE CAN MERGE
What and why?
In this PR:
_footer.scssfile for better maintainabilityNotes:
Relates to sc-12329; blocked by #949
How to test
Take a look at the preview or compare the screenshots: LIVE PREVIEW
Before
After
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist