-
Notifications
You must be signed in to change notification settings - Fork 3
[SC-XXX] Expose log_test_result function #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pull requests must include at least one of the required labels: |
This allows a user to skip most of the vm-library machinery and just send results to ValidMind. Amp-Thread-ID: https://ampcode.com/threads/T-0d15caf4-4ac4-4ff4-b7e1-9be6ed2590f7 Co-authored-by: Amp <amp@ampcode.com>
39ee4dd to
dc4e341
Compare
johnwalz97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 👌
cachafla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I'd suggest a minor version bump since we're adding a new method to the API.
PR SummaryThis PR introduces a new function, log_test_result, in the API client, which allows logging of test result information. The function acts as a synchronous wrapper around its asynchronous counterpart, alog_test_result, using run_async. The update ensures that log_test_result is also imported in the package's init.py and exposed as part of the public API. This enhancement enables users to log test results with additional metadata such as section ID, position, and configuration flags to handle sensitive data. Overall, the changes integrate test result logging into the existing API in a manner consistent with the current design. Test Suggestions
|

Pull Request Description
What and why?
Exposed the
log_test_resultfunction as a public API invalidmind.api_client,validmind.client, and the top-levelvalidmindpackage. This allows users to programmatically log test results without using the internalalog_test_resultasync function directly.How to test
What needs special review?
None.
Dependencies, breaking changes, and deployment notes
None.
Release notes
Exposed
validmind.log_test_result(andvm.log_test_result) to allow logging test result dictionaries directly to the API synchronously.Checklist