Improve logic and reduce failures on personal repos#124
Merged
roshkhatri merged 2 commits intovalkey-io:mainlinefrom Feb 24, 2026
Merged
Improve logic and reduce failures on personal repos#124roshkhatri merged 2 commits intovalkey-io:mainlinefrom
roshkhatri merged 2 commits intovalkey-io:mainlinefrom
Conversation
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
zuiderkwast
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would resolve the issue where the build workflow fails for personal repos where all or some secrets are not saved.
Also added a change where maintainers can publish multiple versions for the workflow triggers. This comes in handy when we have CVE fixes for base image or any other components which are not necessarily tied with valkey versions.
this workflow tests this all these changes: https://github.com/roshkhatri/valkey-container/actions/runs/22168758033