Skip to content

Comments

Improve logic and reduce failures on personal repos#124

Merged
roshkhatri merged 2 commits intovalkey-io:mainlinefrom
roshkhatri:tag-personal-repo-runs-fails
Feb 24, 2026
Merged

Improve logic and reduce failures on personal repos#124
roshkhatri merged 2 commits intovalkey-io:mainlinefrom
roshkhatri:tag-personal-repo-runs-fails

Conversation

@roshkhatri
Copy link
Member

@roshkhatri roshkhatri commented Feb 19, 2026

This would resolve the issue where the build workflow fails for personal repos where all or some secrets are not saved.

Also added a change where maintainers can publish multiple versions for the workflow triggers. This comes in handy when we have CVE fixes for base image or any other components which are not necessarily tied with valkey versions.

this workflow tests this all these changes: https://github.com/roshkhatri/valkey-container/actions/runs/22168758033

  1. input multiple versions
  2. Able to publish to the image repositories where partial secrets are set and the WFs wont fails.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Copy link
Member

@Nikhil-Manglore Nikhil-Manglore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually LGTM. I don't know this workflow well enough so it's better to rely on other reviewers (such as Nikhil).

@roshkhatri roshkhatri merged commit b1bf00c into valkey-io:mainline Feb 24, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants