Merged
Conversation
Replace usage of shared "*Edition" placeholders with direct local responses and per-entity state updates across stores (camera, commands, config, ias, items, projets, projettags, stores, tags, users). Key changes:
- Set loading flags on individual nested entities (e.g. this.items[id].loading) instead of overwriting objects via spreads.
- Initialize nested maps before use (if (!this.items[id]) this.items[id] = {}).
- Use local variables for fetch results (const item = await ...) and write results directly into the relevant store maps instead of assigning to global edition objects.
Introduce hasPermission action in auth store and migrate components to use it instead of direct role_user comparisons.
Introduce src/utils/buildRSQLFilter.js and export it from utils/index.js to centralize RSQL filter construction. Integrate the new filter builder across multiple components, stores and views (Filter, FilterContainer, Tags, Tableau, Commentaire, many store modules and views) to standardize query/filter logic. package.json now includes lodash-es and other dependency updates were applied. This centralization simplifies filter handling and keeps query generation consistent across the frontend.
Change Tableau component to a unified fetch signature and add listFetchFunction handling. The fetchFunction now accepts (limit, offset, expand, filter, sort, clear) and meta.expand is supported; refetchListData is invoked after interval fetches. Added listFetchFunction (array) to request related resources for loaded intervals. Updated Tags and Tableau usages across many views to pass :fetch-function and :total-count, set meta.expand where needed, and use Object.fromEntries for datalist options. Removed many initial bulk onMounted prefetch loops in favor of interval/lazy loading and simplified modal open handlers. Overall improves lazy-loading of related entities and standardizes table fetching behavior.
Update various stores to read total counts from new response.pagination.total (fallback to 0) instead of the old count field. Interval/listing methods now return pagination nextOffset and hasMore so callers can handle cursor-style pagination. Adjust per-entity total count assignments where totals are keyed by parent id.
Refactor locale JSONs to standardize keys and split list/detail variants.
Replace concatenated length/size messages with parameterized translations ({count})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to core frontend components, focusing on better data handling, more flexible filtering, and improved user session management. The most significant changes include refactoring comment and filter components to use explicit user and config objects, updating filtering logic to support object-based options, and enhancing permission checks in form components and improve filtering and managing comments.