Expose some functions for async users who accepts the connection themselves#147
Open
RaitoBezarius wants to merge 2 commits intovarlink:masterfrom
Open
Expose some functions for async users who accepts the connection themselves#147RaitoBezarius wants to merge 2 commits intovarlink:masterfrom
RaitoBezarius wants to merge 2 commits intovarlink:masterfrom
Conversation
Users who want to follow the same logic that the library does while handling socket activation themselves could benefit from having this function pub. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
End users who are manipulating the stream themselves can benefit from calling these functions themselves and handling the I/O. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
RaitoBezarius
force-pushed
the
master
branch
from
5d8b57f to
649094d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146.
The rationale is described in commit messages but it boils down to: it's very hard to accept connections yourselves and reuse these logic.